ScriptureFilter Update
June 18, 2007 - 7:07am
added or changed
This is pretty neat. I played around with it a little bit. Though, a couple things to note:
1) The collapsible block version doesn't work. I get javascript errors on the page and nothing happens.
2) I noticed none of your stuff is in patch format. You can read up on patches at http://drupal.org/patch.
3) The Scripture Filter maintainer is not known for his speed in responding. After a couple weeks and when you have this setup working pretty well (gracefully degrading and all) you may want to contact him via email.
The feature I would love to see fully working is the audio version. That is one of the killer features.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 18, 2007 - 9:00am
Jquery missing...
I have updated the module to fix the block problem. I forgot that just becuase jquery is core doesn't mean it is automatically loaded! It was working as for me as it was loading it for admin...
Anyhow! Fixed now and the zip file is updated. I'll do a fresh patch file (worked out how to do these on a windows machine yesterday!) when I get home from work.
I'll give some though to gracefully degrading if js is unavailable... What do you think, just drop back to external link?
Cheers
Andy
June 18, 2007 - 1:41pm
auto attach?
When you add javascript to a link are you putting it in the link?
The workflow I would see, for graceful degradation would have it generate an external link on page load. Than, the javascript would remove that link and add an event to the link that does something. The javascipt could be in an external file or in the head.
Does this make sense?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 18, 2007 - 2:22pm
I Think so...
So put the link in then get js to replace the link with something new when it is available...
I'll give it some thought...
Andy
June 18, 2007 - 3:31pm
exactly
That's how graceful degradation works, usually. There is no javascript in the body. The javascript at page load attaches and alters the elements it needs to. There are some exceptions like SWFObject but they are rare and are not the rule. Especially with jquery with has a way of loading elements faster than the onload attribute on the body.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 18, 2007 - 5:17pm
AJAX?
Should I be pulling the text down with AJAX?
I have worked out that I can pull text down with the .load and .get jquery commands, but I'm not sure how to get the text out of the module where it is generated. I suppose I could move a lot of the code out into a php file which could be called, does this sound like a good approach?
Never done anything with AJAX.
Andy
June 18, 2007 - 5:37pm
try this....
Here's a thought.... err logical flow....
Have it setup so that each item is a link to the offsite page (so it gracefully degrades).
Then have a javascript function that's linked to in the head. Have the function be something like Drupal.scripturefilter.attach. This is descriptive and and keeps itself in a module name spacing so there won't be conflicts with other modules.
This function would go through the page and attach javascript to each of your links. Maybe do it by class and add the class scripturefilter to each link when you create the links.
Then use Drupal.extent to add any settings/info to the page that are needed for the particular items. You would use something like drupal_add_js($mysettings, 'setting'). This will do the Drupal.extend work.
Does this make sense? You can see some usage of drupal_add_js for settings at http://cvs.drupal.org/viewcvs/drupal/drupal/includ.... Just do a search.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 18, 2007 - 5:57pm
Sorry...
Sorry, probably gettting a little out of my depth now! Quite happy tinkering with PHP but am really struggling to work out how to get the text from the module into the js.
I think I can add the javascript to the links using something like
$('a.scripturefilter').append("<span class='addscripture'> Add text here </span>";The module generates the text, but I am not sure how to pass this to the javascript. I figured I could use something like
$('span.addscripture').load(...link to something...);I just can't work out what the something should be!
I tried making a php file but it fell apart due to the fact I couldn't use the drupal functions. Should I add a host of includes to the begining? It just feels like I am going to end up with a huge sledgehammer for a tiny nut!
Sorry!
Andy
June 18, 2007 - 6:17pm
Cache
I meant to clarify part of the problem is that the text of the verses is cached using the built in drupal cache system, so I need a way of retrieving the text from there...
I could still use the main module to retreve the text and cache it and then use some make a php file of some description which can pull the text from the cache...
Any ideas how I could make such a php file that would have access to the core drupal functions? Which file do I need to include?
Thanks for your help!
Andy
June 19, 2007 - 8:18am
store as an array
When you generate the page you could grab all the verses from the cache, or from where ever, and store them in a javascript array to be called to later. Do the drupal_add_js for a setting to insert the array right into your jquery function. This setting javascript won't be in a separate file but in the head of your page and that's ok. jQuery allows you to have code in the head of your page that extends or becomes part of another jquery function that can be loaded from an outside file.
So, static javascript in outside file. Array or other variables that need to pull in info from php in head.
Some general reading at http://docs.jquery.com/Plugins/Authoring
http://jquery.bassistance.de/jquery-getting-starte...
http://drupal.org/search/node/jquery+type%3Abook
Please note, in the jquery documentation they say name things like jQuery.pluginname. Instead, name them Drupal.modulename. The namespacing is different so we don't cross with any other functions. Also, when extending a Drupal.modulename function use Drupal.extend instead of jQuery.extend.
Make sense?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 21, 2007 - 7:00pm
Getting there...
Okay the worst of my reports to write for school are out of the way so I managed to find a couple of hours to look at this ...
I have something that now works, although I am sure it could be coded neater than this...
To make it work I had to turn of the caching of the input filter as it would only pass the data to the javascript variable the first time it fired... I guess I should really use ajax to call the variable into the header once it has loaded but I still have no real clue how to...
Once the variable is in the header it uses a short jQuery to rewrite the link into the expandable block.
It seems to degrade neatly now, although ajax is definitely the next step as I can then get caching back on and reduce the download burden on non-java clients.
Can you take a look and let me know any further thoughts and or improvments... as ever the code is all attached as a zip file at the bottom of the page.
Cheers
Andy
June 21, 2007 - 7:19pm
without AJAX
You can do this without AJAX. AJAX would mean having to go to the server after the page has loaded. You can load all of the scripture stuff into variables for that page so there is no second time going back to the server for more info.
What is the node on drupal.org that you are working on this stuff on? We should take this discussion there.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
June 22, 2007 - 2:56am
Drupal Issue Node
The stuff I have posted thus far is in the following node
Andy
June 22, 2007 - 6:19pm
More changes...
I have made a few more changes to the module. I would love to get some more feedback from people as to whether they think it is any good, and what if anything they would like to work differently.
Demo of the module can be found:
http://sandbox.1kemp.co.uk
Cheers
Andy
June 24, 2007 - 10:52am
Greek Text Added!
Okay, I think it is now stable and feature complete. 3 new translations added - New Life Version, NRSV and the Greek Septuagint - including a very nice flash player which is hidden within a collapsible block.
I have tidyed up the code, annotated where appropriate and the latest version is now installed on the sandbox site http://sandbox.1kemp.co.uk
Please have a play and let me know if anything doesn't work! If you want it to do anything else let me know and I'll give it some thought.
Andy
June 24, 2007 - 2:08pm
July 1, 2007 - 10:40pm
you saved my bacon!
so to speak... I needed something that does just what this module does, and I did not ( and do not) have time enough to build it in the week or so that remains before our church's website goes live, in conjunction with an area-blitzing launch of our newly relocated church.
I left some comments at http://drupal.org/node/149898.
Thanks for all your work on this tool! I really enjoyed the back-and-forth between you and Matt while he mentored you on this project, and you kept pluggin' away until you got it. Good for you!
May God richly repay you for the hours you invested in this project for His kingdom. --Gary
July 14, 2007 - 1:57pm
Works with input format set to filtered html but not full html
I'm getting around to setting up this module on our site. It works fine with filtered html on but the flash player for the audio using the ESV doesnt show. If I select full html the module doesnt work at all.
Is there any settings I need to change to make this work properly?
July 14, 2007 - 2:49pm
Some results but not quite everything.
I have the scripture filter working for the collapsable blocks but the flash audio player isnt showing. But if I hover the mouse over to where it should be, my cursor turns to a hand and I can click on it and listen, just the controls dont show up.
Edit: Duhhh. Never mind me. I forgot flash doesnt display when previewing content. Once I submitted it, everything was all good. Such a dork sometimes. :)
July 14, 2007 - 4:20pm
it happens....
It happens to the best of us....
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
July 14, 2007 - 4:24pm
Thanks again Andy
I got the module installed and working fine on on our site. Particularly helpful in our Bible Q&A posts. I'm already getting some good feedback from visitors about it. I appreciate all the hard work you put into this. Many thanks
July 14, 2007 - 4:27pm
July 14, 2007 - 6:08pm
Happy to Help!
I am really pleased to see my work being used so effictively! Hopefully we can geta couple of people to have a proper dig through the code so we can tidy it up and release it properly...
Thanks,
Andy
July 15, 2007 - 2:32am
Add own translation
Andy, Our pastor has his own literal translation he does each week that he includes in the study guides passed out at church. You can view some of his literal translation in one of the recent study guides HERE. How difficult would it be for us to include this instead for the scripture filter?
I would love to add this as an option in the scripture filter and have the block drop down portion work with it. Have an alternative bible version for people and have it without any restrictions on usage.
July 16, 2007 - 7:11am
surfing isn't driving
Working on websites never killed anyone (as far as I know) so you should be all right. Hope you did something good to tear that... ouch!
Just remember... when doped up... backup before you make database changes.
Hope you feel better soon.... going in for surgery?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
July 16, 2007 - 7:13am
I'll go through it soon
Sorry I have been so busy. I'll go through the code soon. It's amazing how busy a wedding, moving, and just being married is. I have barely had time to review any code... at all.
Soon though... soon.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
July 16, 2007 - 7:24am
A different way
This might be hard to do. What scripture filter does it parse through posts and insert the information or link to scriptures from a site like biblegateway.com. So, when we type them in we don't have to add the links or data.
With the modifications we have the ability to add them in there inline and add audio to that because the ESV provides the audio.
But, who is going to manage a database and interface for your pastors translation? So that scripture filter can automatically insert the text. Is it worth the work to compile and manage that? Make sense?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
July 16, 2007 - 8:41am
Very good point on the work
Very good point on the work that will be involved with managing the database. It does sound like its a lot of effort. The pastor still has a way to go to translate the entire Bible. When finished with it I would love to be able to get it out there as a free translation for everyone to have. It really is a fantastic literal translation. When the time comes I think I would like to look into this more and set up something where it would be possible to manage this database and have it out as a free resource for everyone.
Another side project is his Greek Course. It was originally just tapes and notebook. Converted everything to digital and PDF then on CD that installs on PC using a Adobe Reader application for the entire course along with hours and hours of embedded audio for each page. Originally I did it because when I took the course I couldnt stand cassette tapes and I wanted it all on my computer. So the project began from there. You can see a Flash preview of the course here. I really want the price lower but its being used now as curriculum for a theology school. He is bound I think by contract to sell it at its current price.
I want to be able to make a better interface for it and learn some mac programming and make it an awesome greek course for mac users. But dont know where to start.
Just a lot I want to do and just make available for everyone but time and resources are a major thing. Ok Im rambling now. Ill stop :)
July 16, 2007 - 8:45am
July 16, 2007 - 10:54am
No problem!
I completely understand! Take yor time...
Remeber whatever happens your family are always more important than any piece of code!
Thanks,
Andy
July 16, 2007 - 11:04am
Adding a translation...
I gave this some thought over the weekend, and in theory if you were only looking to make your translation available on your site it might be possible to canabalise the scripturefilter module to do something like that.
What you would need to do is replace the section of code that calls the ESV text with a custom function which calls the scripture from a MySQL database.
That said I side with MF this is going to be a fair amount of work, and doesn't really fit the remit of scripture filter.
If you are really keen to pursue this thought drop me a PM and I might be able to point you in the right direction...
Cheers,
Andy
July 16, 2007 - 11:22am
More To It Than Translation
If you honestly want to go the road of another translation, getting it out there, and getting it to be useful there will be a lot more to it than just having the translation.
To make it popular and used you will need to have more value added.
Let me try to explain what I mean. If you are looking for a very literal translation there is already the New American Standard Version (NAS). The NAS has corresponding Strongs Concordinances, Lexicons, and loads of other support material to go along with it. This is more than having it be embeddable in a website or searchable.
If you are looking for something more contemporary the NIV already exists and is very widely spread. Many bible studies use this version.
Just having a translation doesn't mean that people will use it. Just having it available doesn't mean people will read it. Look at the Gods Word Translation. This translation struggled to get use even though it is considered by scholar to be fairly good as far as transliterations go (not exact translations but like the Message where it gets the point across). It has gotten more use in recent years when the publisher gave more value added to using that translation.
So, it's not just a matter of having a translation and having it available on the internet. There is a lot more to it and that ends up being a lot more work. Is that really going to be a pursuit?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
July 16, 2007 - 11:32am
Will start looking into it
Thank you Andy. Im going to look into it and let the pastor and the other guy that helps me with the site know about the work that will be involved and to verify this is the direction they want to head in. Once I find that out, then I will get back to you via PM and if your still up for giving me some tips on how to do this, then I will definitely take what knowledge you have on this.
Thanks again Andy.
July 16, 2007 - 11:36am
I agree
I would focus on getting it on to your own site and using it how you want to if you/your pastor feels it is a valuable addition to website/ministry.
As MF points out though there are already a large number of translations available and you need to ask yourself what does yours provide that one of the current ones doesn't
If you are insterested in pushing it as a translation more widly than this then I would suggest you speak to a publisher who can help you think this through properly!
Andy
July 16, 2007 - 11:53am
I think thats the best way
I think thats the best way as well to go about it. Make it available on the site first. Eventually it will get translated each weekly study guide contains this literal translation. As you can see in this Study Guide Once that is done we can compile it all together then have a completed translation for whatever use we want.
Im going to share this information with him so he can think about it.
Thanks again guys.
July 16, 2007 - 9:24pm
Spoke to the pastor
I spoke to the pastor today and he wanted to hold off for now. Understanding that its a lot of work, and work that isnt needed right now. Time will be focused on other projects. Saved me some sweat thats for sure :). Thanks again for the explanations and offers of help. Much appreciated
August 28, 2007 - 7:03am
More Help Needed!!
Matt,
I am having a wierd problem with the updated ScriptureFilter, it seems to work well everywhere apart from on my frontpage. I assume this is becuase I am using a custome template for the frontpage and I have missed something out!
The filter works correctly and puts the link in however it should also pass a js variable with the html code for the expandable block but it isn't doing this on the frontpage.
I have included the php code used on the page-front.tpl.php below:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php print $language ?>" lang="<?php print $language ?>">
<!-- Version: Multiflex-3 Update-7 / Layout-4 -->
<!-- Date: January 15, 2007 -->
<!-- Author: Wolfgang -->
<!-- License: Fully open source without restrictions. -->
<!-- Please keep footer credits with a link to -->
<!-- Wolfgang (www.1-2-3-4.info). Thank you! -->
<!-- Modified for Drupal 5.0 by Christopher Doyle -->
<?php
/**
* This is the custom template for the frontpage of the website!e
*/
?>
<head>
<title><?php print $head_title ?></title>
<?php print $head ?>
<?php print $styles ?>
<?php print $scripts ?>
<script type="text/javascript" src="<?php print base_path(). path_to_theme() ?>/swfobject.js"></script>
<script type="text/javascript" src="<?php print base_path(). path_to_theme() ?>/external.js"></script>
<script type="text/javascript" src="<?php print base_path(). path_to_theme() ?>/menu.js"></script>
<script type="text/javascript" src="<?php print base_path(). path_to_theme() ?>/search.js"></script>
<script type="text/javascript" src="<?php print base_path(). path_to_theme() ?>/taxonomy.js"></script>
<style type="text/css">@import "<?php print base_path() . path_to_theme() ?>/css/layout4_setup.css";</style>
<style type="text/css">@import "<?php print base_path() . path_to_theme() ?>/css/layout4_text.css";</style>
<style type="text/css">@import "<?php print base_path() . path_to_theme() ?>/css/style.css";</style>
<style type="text/css">@import "<?php print base_path() . path_to_theme() ?>/css/site.css";</style>
<script type="text/javascript">
jQuery.noConflict();
</script>
<script src="<?php print base_path() . path_to_theme() ?>/smoothgallery/scripts/mootools.js" type="text/javascript"></script>
<script src="<?php print base_path() . path_to_theme() ?>/smoothgallery/scripts/jd.gallery.js" type="text/javascript"></script>
<!--[if lt IE 7.]>
<script defer type="text/javascript" src="<?php print base_path() . path_to_theme() ?>/pngfix.js"></script>
<![endif]-->
<link rel="alternate" type="application/rss+xml" title="News Feed RSS" href="<?php print base_path()?>news/feed/" />
<link rel="stylesheet" href="<?php print base_path() . path_to_theme() ?>/smoothgallery/css/jd.gallery.css" type="text/css" media="screen" charset="utf-8" />
<style type="text/css">@import "<?php print base_path() . path_to_theme() ?>/css/frontpage.css";</style>
</head>
<!-- Global IE fix to avoid layout crash when single word size wider than column width -->
<!--[if IE]><style type="text/css"> body {word-wrap: break-word;}</style><![endif]-->
<body<?php //print phptemplate_body_class($sidebar_left, $sidebar_right); ?>>
<!-- Main Page Container -->
<div class="page-container">
<!-- For alternative headers START PASTE here -->
<!-- A. HEADER -->
<div class="header">
<!-- A.1 HEADER TOP -->
<div class="header-top">
<!-- Sitelogo and sitename -->
<?php
$site_name = check_plain($site_name);
$base_path = check_url($base_path);
$logo = check_url($logo);
if ($site_name && $logo) {
print "
<a class=\"sitelogo\" href=\"$base_path\" title=\"$site_name\"><img src=\"$logo\" alt=\"$site_name\" id=\"logo\" /></a>";
}
?>
<!-- Navigation Level 0 -->
<!-- <div class="nav0">
<ul>
<li><a href="#" title="Pagina home in Italiano"><img src="./img/flag_italy.gif" alt="Image description" /></a></li>
<li><a href="#" title="Homepage auf Deutsch"><img src="./img/flag_germany.gif" alt="Image description" /></a></li>
<li><a href="#" title="Hemsidan på svenska"><img src="./img/flag_sweden.gif" alt="Image description" /></a></li>
</ul>
</div>-->
<!-- Navigation Level 1 -->
<?php if (isset($primary_links)) : ?>
<?php print theme('links', $primary_links, array('class' => 'nav1')) ?>
<?php endif; ?>
</div>
<!-- A.2 HEADER MIDDLE -->
<div class="header-middle" onclick="location.href='<?php print base_path()?>';" style="cursor: pointer;">
<!-- Site message -->
<div class="sitemessage">
<?php if ($site_slogan): ?>
<h1><?php print $site_slogan; ?></h1>
<?php endif; ?>
<?php $mission = variable_get('site_mission', ''); if ($mission): ?>
<h2><?php print $mission; ?></h2>
<?php endif; ?>
</div>
<!-- Search form -->
<?php if ($search_box) :?>
<div class="searchform" onclick="event.cancelBubble=true;">
<?php print $search_box; ?>
</div>
<?php endif; ?>
</div>
<!-- A.3 HEADER BOTTOM -->
<div class="header-bottom">
<!-- Navigation Level 2 (Drop-down menus) -->
<div id ="nav2" class="nav2">
<!-- Navigation items -->
<?php if (isset($secondary_links)) {
// build two level menu for secondary links
//TODO: there will almost certainly be an IE6/IE7 problem with
// these menus... see the original template on how to fix
$msm = variable_get('menu_secondary_menu', 0);
print theme('menu_tree', $msm);
} ?>
</div>
</div>
<!-- A.4 HEADER BREADCRUMBS -->
<!-- Breadcrumbs -->
<div class="header-breadcrumbs">
<?php if ($header) { print $header; } ?>
</div>
</div>
<!-- For alternative headers END PASTE here -->
<!-- B. MAIN -->
<?php
if (!$sidebar_left && !$sidebar_right) {
$wide_class = ' doublewide';
} else if (!$sidebar_left) {
$wide_class = ' nonav';
} else if (!$sidebar_right) {
$wide_class = ' noblocks';
}
?>
<div class="main<?php print $wide_class; ?>">
<!-- B.1 MAIN NAVIGATION -->
<?php if ($sidebar_left): ?>
<div class="main-navigation sidebar" id="sidebar-left">
<?php print $sidebar_left ?>
</div>
<?php endif; ?>
<!-- B.1 MAIN CONTENT -->
<div class="main-content">
<div class="encouragement">
<?php
$view = views_get_view('Encouragement');
print views_build_view('page', $view, array(), false, 1);
?>
</div>
<script type="text/javascript">
function startGallery() {
var myGallery = new gallery($('myGallery'), {
timed: true,
showArrows: false,
showCarousel: false
});
}
window.onDomReady(startGallery);
</script>
<div id="myGallery">
<?php
$view = views_get_view('frontpage');
print views_build_view('page', $view, array(), false, 5);
?>
</div>
<div class="boxleft" >
<span class="services">Sunday Services</span>
<div class="servicetimes">
<b style="margin-top:15px">Location</b><br />
Castle Hill Baptist Church<br />
Warwick<br />
CV34 4EX<br />
<b style="">Service Times:</b><br />
10:30 am<br />
6:30 pm
</div>
<div class="locationmap" onclick="location.href='<?php print base_path() ?>contactus/map';" style="cursor: pointer;">
</div>
</div>
<div class="boxright">
<span class="services">Most Recent Morning Talk</span>
<?php
$view = views_get_view('morningsermon');
print views_build_view('page', $view, array(), false, 1);
?>
</div>
</div>
</div>
<!-- C. FOOTER AREA -->
<div id="footer" class="footer">
<p><?php print $footer_message ?></p>
<p class="credits">Design by <a href="http://www.1-2-3-4.info/" title="Designer Homepage">Wolfgang</a> | Adapted by <a href="http://www.codingclan.com" title="CodingClan">CodingClan LLC</a> | Powered by <a href="http://drupal.org" title="Drupal">Drupal</a> | <a href="http://validator.w3.org/check?uri=referer" title="Validate XHTML code">XHTML 1.0</a> | <a href="http://jigsaw.w3.org/css-validator/" title="Validate CSS code">CSS 2.0</a></p>
</div>
</div>
</body>
</html>The code isn't the prettiest, so I hope it makes sense!
Any help greatfully appreciated!
link to frontpage is currently Front Page
Andy
August 28, 2007 - 8:05am
mootools?
There is a lot of javascript being executed here. I wonder if any of it is interfering with other parts. What happens when you take mootools out of the page? Does it start to work?
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
August 28, 2007 - 8:33am
Tried...
Tried taking it all out and leaving the
<?php
print $scripts
?>The php line in the module is
drupal_add_js("var drupal_scripture".$passage_java." = " . drupal_to_js($output_dynamic) . ";", 'inline');Which should add something like
<script type="text/javascript">var drupal_scripture_James_2_18 = "\x3ca href=\"javascript://\" onclick=\"esvshowhide(\'scripturefilter14840304\')\"\x3eJames 2:18 [+/-]\x3c/a\x3e\x3cspan class=\'bibleref\' title=\'James 2:18\' id=\"scripturefilter14840304\" style=\"background-color: white;display: none;padding: 10px;border: dotted #E1E1E1 1px;border-left: solid #E1E1E1 10px;color: black;\"\x3e\x3cspan style=\'font-size:20px;\' class=\'passageheading\'\x3eJames 2:18 \x3cobject type=\"application/x-shockwave-flash\" data=\"http://www.gnpcb.org/esv/share/audio/flash/play.swf?myUrl=mm%2F59002018\" width=\"40\" height=\"12\" class=\"audio\"\x3e\x3cparam name=\"movie\" value=\"http://www.gnpcb.org/esv/share/audio/flash/play.swf?myUrl=mm%2F59002018\" /\x3e\x3cparam name=\"wmode\" value=\"transparent\" /\x3e\x3c/object\x3e\x3c/span\x3e\x3cspan style=\'display:block;\' class=\'passagetext\'\x3e\x3cspan class=\"verse-num\" id=\"v59002018-1\"\x3e18\x26nbsp;\x3c/span\x3eBut someone will say, \x26#8220;You have faith and I have works.\x26#8221; Show me your faith apart from your works, and I will show you my faith by my works. (\x3ca href=\"http://www.esv.org\" class=\"copyright\"\x3eESV\x3c/a\x3e)\x3c/span\x3e\x3c/span\x3e";</script>see Romania Prjoect page for an example...
Thanks
Andy
August 28, 2007 - 10:37am
I dunno
I don't see anything that jumps out at me. But, I don't know this module very well. I wonder if there is something that isn't loading.
Do you have views on other pages where the scripture filter works for content in a view? I see yoru homepage is generated by views.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
August 28, 2007 - 11:11am
I had the same thought...
I had the same thought too!
I checked the page for the view:
http://beta.warwickbaptists.org.uk/morningsermon
and also tried putting the same code into the body section of a post and it worked...
I'll have a go at putting it into another template page...
Thanks for trying...
Andy
August 28, 2007 - 11:23am
Same problem...
I stuck the
<?php
$view = views_get_view('morningsermon');
print views_build_view('page', $view, array(), false, 1);
?>at the end of the page-fonrt.tpl.php and it didn't generate the javascript there either... hmm... So it seems to be an issue with calling a view within the template...
Is there another way I can call the view?
Andy
August 28, 2007 - 1:03pm
an issue
I think we have an issue here. Not sure of the fix. I'd have to learn how and when a view is typically called in code and compare the difference to this.
Though, I don't really have time. I'd hit up the drupal site and see if you can get one of the devs of these modules to take a look. They might already know the answer to these questions.
Another thought, instead of inserting them like this make the views into blocks, stick regions where you want them, and assign those blocks to those regions.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
August 28, 2007 - 1:39pm
Thanks
Thanks for taking a look. I have tweaked the js code so that it checks if the variable has been defined and only replaces the link if it has. Otherwise it was just stripping out all the Bible references on the front page.
That will do me for now, until I have more time to look into this properly!
Any chance you will have some time to look through the module code at some point, as I would quite like to offer it round properly...
Thanks,
Andy
August 29, 2007 - 7:43am
at some point
At some point I'll be able to. But, it won't be this month. I have a few high priority projects to get done.
Matt Farina
Geeks and God Co-Host
www.mattfarina.com
I have been working on rewriting the ScriptureFilter module to take advantage of the ESV's API. These updates are based around the two scripture plugins available for Wordpress but have been ported and combined into a new drupal module.
I am still waiting to hear back as to whether the Scripture Filter team want to include these changes or if I should fork it off into a new module.
Anyway this is still a dev release but if you are interested you can have a play with it on my sandbox site:
Sandbox Site
The issue thread this has been discussed (if you can call a monolouge a discussion!?!) can be found here
Any thoughts, commments suggestions for improvements gratefully received!
Cheers
Andy
Warwick Baptist Church - The Kemps' Blog
Andy
Warwick Baptist Church - The Kemps' Blog